Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Fix TestCancelQuery #1226

Merged
merged 2 commits into from
Oct 24, 2024
Merged

NO-SNOW Fix TestCancelQuery #1226

merged 2 commits into from
Oct 24, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Oct 22, 2024

Description

NO-SNOW Fixes TestCancelQuery, which was failing when query finishes too quickly.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review October 22, 2024 12:21
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 22, 2024 12:21
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (251a6cd) to head (2338ecb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files          55       55           
  Lines       13194    13194           
=======================================
  Hits        10924    10924           
  Misses       2270     2270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus merged commit 58c35d4 into master Oct 24, 2024
36 of 37 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the test-cancel-fix branch October 24, 2024 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants